Bug 234538 – [WebIDL] Eagerly allocate element wrappers onto a butterfly storage of a static NodeList

• Status: REOPENED
• Component: Bindings

[Alexey Shvayka]

Preliminary microbenchmark results suggest 65% speed-up if a static NodeList is iterated at least once.

[Radar WebKit Bug Importer]

<rdar://problem/86946513>

[Alexey Shvayka]

Created attachment 448520 [details]
WIP

[Geoffrey Garen]

Comment on attachment 448520 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=448520&action=review

> Source/JavaScriptCore/runtime/JSTypeInfo.h:113
> +    bool getOwnPropertySlotByIndexIsWrongAboutReadOnly() const { return isSetOnFlags2<GetOwnPropertySlotByIndexIsWrongAboutReadOnly>(); }

I'd suggest a name that describes what is true rather than what is false. Maybe something like "IndexedPropertiesAreReadOnly" or "PutByIndexOverrideWillProhibitWrites" or something like that.

[Alexey Shvayka]

Pull request: https://github.com/WebKit/WebKit/pull/2915

[EWS]

Committed 253834@main (e0c79898e6c5): <https://commits.webkit.org/253834@main>

Reviewed commits have been landed. Closing PR #2915 and removing active labels.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 244444

[Alexey Shvayka]

Pull request: https://github.com/WebKit/WebKit/pull/3786

[EWS]

Committed 253946@main (9d5bc2bbab71): <https://commits.webkit.org/253946@main>

Reviewed commits have been landed. Closing PR #3786 and removing active labels.

[Alexey Shvayka]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/3902

[EWS]

Committed 254036@main (de4790b17831): <https://commits.webkit.org/254036@main>

Reviewed commits have been landed. Closing PR #3902 and removing active labels.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 245151

[Darin Adler]

Before re-landing this check to make sure we don’t reintroduce bug 244900.