Bug 234535 - Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Summary: Momentum Event Dispatcher: Momentum tails may get truncated if the duration r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-20 15:59 PST by Tim Horton
Modified: 2022-01-05 13:58 PST (History)
7 users (show)

See Also:

Attachments
Patch (23.73 KB, patch)
2021-12-20 16:02 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (23.70 KB, patch)
2021-12-20 16:58 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (24.37 KB, patch)
2021-12-20 21:30 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (25.62 KB, patch)
2022-01-04 17:00 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (25.78 KB, patch)
2022-01-04 17:40 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (25.52 KB, patch)
2022-01-04 22:12 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-12-20 15:59:30 PST 
Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Comment 1 Tim Horton 2021-12-20 16:02:37 PST 
Created attachment 447657 [details]
Patch
Comment 2 Tim Horton 2021-12-20 16:02:40 PST 
<rdar://problem/86338105>
Comment 3 Simon Fraser (smfr) 2021-12-20 16:13:02 PST 
Comment on attachment 447657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447657&action=review

> Source/WebKit/Shared/mac/WebEventFactory.mm:414
> +    WallTime ioHIDEventWallTime = timestamp;

auto

> Source/WebKit/Shared/mac/WebEventFactory.mm:416
> +    WebWheelEvent::MomentumEndType momentumEndType = WebWheelEvent::MomentumEndType::Unknown;

auto
Comment 4 Tim Horton 2021-12-20 16:58:39 PST 
Created attachment 447666 [details]
Patch
Comment 5 Tim Horton 2021-12-20 21:30:34 PST 
Created attachment 447687 [details]
Patch
Comment 6 Tim Horton 2022-01-04 17:00:21 PST 
Created attachment 448349 [details]
Patch
Comment 7 Tim Horton 2022-01-04 17:40:15 PST 
Created attachment 448353 [details]
Patch
Comment 8 Darin Adler 2022-01-04 21:12:58 PST 
Comment on attachment 448353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448353&action=review

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:30
> -#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 0
> +#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 1

Was this checked in by accident?
Comment 9 Tim Horton 2022-01-04 22:10:23 PST 
(In reply to Darin Adler from comment #8)
> Comment on attachment 448353 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448353&action=review
> 
> > Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:30
> > -#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 0
> > +#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 1
> 
> Was this checked in by accident?

Good point, need to not accidentally revert r287578!
Comment 10 Tim Horton 2022-01-04 22:12:12 PST 
Created attachment 448359 [details]
Patch
Comment 11 EWS 2022-01-05 11:30:53 PST 
Committed r287641 (245745@main): <https://commits.webkit.org/245745@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448359 [details].
Comment 12 Tim Horton 2022-01-05 13:58:47 PST 
Build fix: https://trac.webkit.org/changeset/287651/webkit