Web Authentication has been shipping for a while, we should remove it as an experimental feature.
<rdar://problem/86743595>
Created attachment 447661 [details] Patch
Created attachment 447722 [details] Patch
Comment on attachment 447722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447722&action=review r=me. So nice to see tons of code deleted! > Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:-503 > -WK_EXPORT bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef); Ordinarily we would want to make this a stub and deprecate it, but I don't find any uses of this call in other (non-WebKit) software so I think this is okay. > LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:7 > +navigator.credentials is OK I assume the WebAuthn bits of navigator.credentials aren't present in WK1, but the top-level namespace exists?
(In reply to Brent Fulgham from comment #4) > Comment on attachment 447722 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447722&action=review > > r=me. So nice to see tons of code deleted! > > > Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:-503 > > -WK_EXPORT bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef); > > Ordinarily we would want to make this a stub and deprecate it, but I don't > find any uses of this call in other (non-WebKit) software so I think this is > okay. > > > LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:7 > > +navigator.credentials is OK > > I assume the WebAuthn bits of navigator.credentials aren't present in WK1, > but the top-level namespace exists? I think the navigator.credentials bits do get put in there as it's only guarded by the macro with this change. I will modify this patch to keep the preference but default false for WebKitLegacy and true for WK2.
Created attachment 447732 [details] Patch
Created attachment 447735 [details] Patch
Comment on attachment 447735 [details] Patch r=me
Committed r287360 (245502@main): <https://commits.webkit.org/245502@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447735 [details].