Bug 234519 - [LFC][IFC] Decouple LineBox and InlineDisplay:Line construction
Summary: [LFC][IFC] Decouple LineBox and InlineDisplay:Line construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-20 11:50 PST by zalan
Modified: 2021-12-20 16:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (26.97 KB, patch)
2021-12-20 11:52 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-20 11:50:05 PST 
While LineBox is all logical, InlineDisplay:Line is physical.
Comment 1 zalan 2021-12-20 11:52:37 PST 
Created attachment 447616 [details]
Patch
Comment 2 Antti Koivisto 2021-12-20 11:58:43 PST 
Comment on attachment 447616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447616&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h:39
> +class InlineDisplayLineBuilder {

Builder is the official pattern of 2021.
Comment 3 EWS 2021-12-20 16:34:41 PST 
Committed r287287 (245439@main): <https://commits.webkit.org/245439@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447616 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-20 16:35:17 PST 
<rdar://problem/86745474>