Bug 234506 - [LCMS] Use std::unqiue_ptr to retain LCMS objects
Summary: [LCMS] Use std::unqiue_ptr to retain LCMS objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yoshiaki Jitsukawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-20 00:29 PST by Yoshiaki Jitsukawa
Modified: 2021-12-21 04:03 PST (History)
11 users (show)

See Also:

Attachments
Patch (18.71 KB, patch)
2021-12-20 01:02 PST, Yoshiaki Jitsukawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2021-12-20 00:29:29 PST 
As pointed out on https://bugs.webkit.org/show_bug.cgi?id=233364#c7, I'd like to introduce LCMSUniqeptr to handle cmsHTRANSFORM and cmsHPROFILE.
Comment 1 Yoshiaki Jitsukawa 2021-12-20 01:02:04 PST 
Created attachment 447590 [details]
Patch
Comment 2 Michael Catanzaro 2021-12-20 07:24:43 PST 
Comment on attachment 447590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447590&action=review

> Source/WebCore/platform/graphics/lcms/LCMSUniquePtr.h:38
> +    void operator() (cmsHPROFILE ptr) const

Why do these have to be const?
Comment 3 Yoshiaki Jitsukawa 2021-12-21 01:34:34 PST 
> Why do these have to be const?

Hmm, I'm not sure it's necesarry to be const but following the signature of the default deleter:
 void operator()(T* ptr) const;
Comment 4 EWS 2021-12-21 02:07:30 PST 
Committed r287306 (245458@main): <https://commits.webkit.org/245458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447590 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-21 02:08:14 PST 
<rdar://problem/86760146>