Bug 234505 - [Win] MSVC reports "DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'" with /std:c++20
Summary: [Win] MSVC reports "DragImageCairoWin.cpp(142): error C2362: initialization o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 233448
  Show dependency tree / graph
 
Reported: 2021-12-19 22:28 PST by Fujii Hironori
Modified: 2021-12-20 11:56 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.98 KB, patch)
2021-12-19 22:30 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2021-12-19 22:40 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-12-19 22:28:26 PST 
[Win] MSVC reports "DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'" with /std:c++20

> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(131): note: see declaration of 'cr'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): note: see declaration of 'exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): error C2362: initialization of 'srcImage' is skipped by 'goto exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(126): note: see declaration of 'srcImage'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): note: see declaration of 'exit'
Comment 1 Fujii Hironori 2021-12-19 22:30:43 PST 
Created attachment 447585 [details]
Patch
Comment 2 Fujii Hironori 2021-12-19 22:40:25 PST 
Created attachment 447586 [details]
Patch
Comment 3 Fujii Hironori 2021-12-20 11:55:03 PST 
Comment on attachment 447586 [details]
Patch

Clearing flags on attachment: 447586

Committed r287268 (245424@trunk): <https://commits.webkit.org/245424@trunk>
Comment 4 Fujii Hironori 2021-12-20 11:55:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-12-20 11:56:23 PST 
<rdar://problem/86734337>