WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WORKSFORME
23449
storage leak in BitmapImage::cacheFrame
https://bugs.webkit.org/show_bug.cgi?id=23449
Summary
storage leak in BitmapImage::cacheFrame
Darin Adler
Reported
2009-01-20 22:52:22 PST
The buildbot is showing a leak in BitmapImage::cacheFrame.
Attachments
patch
(1.52 KB, patch)
2009-01-20 22:55 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2009-01-20 22:52:42 PST
I assume this leak was caused by recent refactoring. It's pretty obvious from code inspection what it could be.
Darin Adler
Comment 2
2009-01-20 22:55:11 PST
Created
attachment 26886
[details]
patch
Alexey Proskuryakov
Comment 3
2009-01-20 23:25:06 PST
Comment on
attachment 26886
[details]
patch r=me
Darin Adler
Comment 4
2009-01-20 23:37:39 PST
Comment on
attachment 26886
[details]
patch On re-reading the code, I'm not sure the patch is correct. It looks like the function should never be called if the frame is non-zero. So I'm clearing the review flag for now. I don't know how to explain the leak seen on the bot.
Darin Adler
Comment 5
2009-01-24 13:06:49 PST
The leak isn't showing up any more. Maybe it was a false positive.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug