Bug 23449 - storage leak in BitmapImage::cacheFrame
Summary: storage leak in BitmapImage::cacheFrame
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2009-01-20 22:52 PST by Darin Adler
Modified: 2009-01-24 13:06 PST (History)
0 users

See Also:

patch (1.52 KB, patch)
2009-01-20 22:55 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-01-20 22:52:22 PST
The buildbot is showing a leak in BitmapImage::cacheFrame.
Comment 1 Darin Adler 2009-01-20 22:52:42 PST
I assume this leak was caused by recent refactoring. It's pretty obvious from code inspection what it could be.
Comment 2 Darin Adler 2009-01-20 22:55:11 PST
Created attachment 26886 [details]
Comment 3 Alexey Proskuryakov 2009-01-20 23:25:06 PST
Comment on attachment 26886 [details]

Comment 4 Darin Adler 2009-01-20 23:37:39 PST
Comment on attachment 26886 [details]

On re-reading the code, I'm not sure the patch is correct. It looks like the function should never be called if the frame is non-zero. So I'm clearing the review flag for now. I don't know how to explain the leak seen on the bot.
Comment 5 Darin Adler 2009-01-24 13:06:49 PST
The leak isn't showing up any more. Maybe it was a false positive.