ntim @ OpenSource ⚡️ import-w3c-tests -t web-platform-tests/html/semantics/interactive-elements/the-dialog-element/ Downloading W3C test repositories Fetching https://github.com/web-platform-tests/wpt.git... Checking out revision origin/master Scanning /Volumes/Data/Code/Safari/OpenSource/WebKitBuild/w3c-tests/to-be-imported/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/... Traceback (most recent call last): File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/import-w3c-tests", line 35, in <module> sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr)) File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 98, in main test_importer.do_import() File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 209, in do_import self.find_importable_tests(self.filesystem.join(self.source_directory, test_path)) File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 352, in find_importable_tests if test_info['type'] == 'mismatch': KeyError: 'type'
Created attachment 447530 [details] Patch
Comment on attachment 447530 [details] Patch r=me, thanks for the fix. This seems to be failing for this test: http://wpt.live/html/semantics/interactive-elements/the-dialog-element/top-layer-position.html Should we add some kind of unit test to avoid breaking this again in the future?
(In reply to Manuel Rego Casasnovas from comment #2) > Comment on attachment 447530 [details] > Patch > > r=me, thanks for the fix. > > This seems to be failing for this test: > http://wpt.live/html/semantics/interactive-elements/the-dialog-element/top- > layer-position.html > Should we add some kind of unit test to avoid breaking this again in the > future? A test would be ideal, though this type of bug is also easily noticeable (I first noticed it importing the whole css/ directory).
Committed r287257 (245413@main): <https://commits.webkit.org/245413@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447530 [details].
<rdar://problem/86716802>