Bug 234458 - Don't pack audio samples with discontinuity together
Summary: Don't pack audio samples with discontinuity together
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
Keywords: InRadar
Depends on:
Reported: 2021-12-17 19:14 PST by Jean-Yves Avenard [:jya]
Modified: 2021-12-19 17:46 PST (History)
2 users (show)

See Also:

Patch (6.45 KB, patch)
2021-12-17 19:38 PST, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (6.45 KB, patch)
2021-12-19 14:27 PST, Jean-Yves Avenard [:jya]
jean-yves.avenard: commit-queue+
Details | Formatted Diff | Diff
Patch (6.45 KB, patch)
2021-12-19 14:43 PST, Jean-Yves Avenard [:jya]
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-12-17 19:14:28 PST
When playing https://jyavenard.github.io/htmltests/tests/mse_webm/83910012/ at 2s we can hear a "chtook" kind of sound.

This stream has a 1ms discontinuity after the first opus packet (20ms), as 2s worth of samples are packed together that discontinuity can be heard at the 2s block boundary.

We shouldn't pack samples together if there's a discontinuity between them so that timestamps stay correct.
Comment 1 Radar WebKit Bug Importer 2021-12-17 19:14:48 PST
Comment 2 Jean-Yves Avenard [:jya] 2021-12-17 19:38:45 PST
Created attachment 447505 [details]
Comment 3 Eric Carlson 2021-12-18 12:10:18 PST
Comment on attachment 447505 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=447505&action=review

> Source/WebCore/ChangeLog:18
> +        So w no longer pack samples with discontinuities so that the frame

s/So w/So we/

> Source/WebCore/ChangeLog:23
> +        in CoreMedia that insert very audible artifacts when there's a gap between

Comment 4 Jean-Yves Avenard [:jya] 2021-12-19 14:27:20 PST
Created attachment 447560 [details]

address comments
Comment 5 Jean-Yves Avenard [:jya] 2021-12-19 14:43:20 PST
Created attachment 447561 [details]

add reviewer name
Comment 6 EWS 2021-12-19 16:04:13 PST
Committed r287249 (245407@main): <https://commits.webkit.org/245407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447561 [details].