Convert ProtectionSpace enums into enum classes.
Created attachment 447494 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 447495 [details] Patch
Created attachment 447499 [details] Patch
Created attachment 447501 [details] Patch
Committed r287224 (245387@main): <https://commits.webkit.org/245387@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447501 [details].
<rdar://problem/86672863>
Comment on attachment 447501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447501&action=review > Source/WebCore/platform/network/ProtectionSpaceBase.h:45 > + HTTP = 1, > + HTTPS = 2, > + FTP = 3, > + FTPS = 4, > + ProxyHTTP = 5, > + ProxyHTTPS = 6, > + ProxyFTP = 7, > + ProxySOCKS = 8 Is there a reason we need to apply specific numbers here instead of letting the enumeration select consecutive numbers? Some reason to avoid 0? > Source/WebCore/platform/network/ProtectionSpaceBase.h:61 > + Default = 1, > + HTTPBasic = 2, > + HTTPDigest = 3, > + HTMLForm = 4, > + NTLM = 5, > + Negotiate = 6, > + ClientCertificateRequested = 7, > + ServerTrustEvaluationRequested = 8, > + OAuth = 9, > +#if USE(GLIB) > + ClientCertificatePINRequested = 10, > +#endif > + Unknown = 100 Same question.