Bug 23445 – Copying certain hidden text causes a crash

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Tom Robinson]

1) Login to reddit.com and visit a comments page
2) Select the text of a comment
3) Click the "[-]" widget for the selected comment to hide it
4) Try to copy the hidden text via keyboard shortcut or menu

Note this only works if you're logged into reddit.com

[Mark Rowe (bdash)]

<rdar://problem/6512520>

[Mark Rowe (bdash)]

*** Bug 24414 has been marked as a duplicate of this bug. ***

[Darin Adler]

Darn, I wanted to work on this bug, but I don't have a reddit.com account. I guess I'll have to make one.

[Darin Adler]

There are two aspects to this bug:

    1) When the end points of the range are no longer rendered due to display: none, it would be good to update the selection so it doesn't include the invisible stuff.

    2) When we actually run the createMarkup algorithm it would be best not to crash.

I have a fix for (2) done. Next I'll make a regression test. Then I'll fix (1) as well.

[Darin Adler]

Created attachment 29052 [details]
patch

[Darin Adler]

(In reply to comment #4)
>     1) When the end points of the range are no longer rendered due to display:
> none, it would be good to update the selection so it doesn't include the
> invisible stuff.

I decided not to fix this at this time. I'm not sure what behavior we want for this.

[Darin Adler]

http://trac.webkit.org/changeset/42096