Bug 234438 - Hash tables, read/write, and heap memory are used unnecessarily, which may hurt performance
Summary: Hash tables, read/write, and heap memory are used unnecessarily, which may hu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-17 11:16 PST by Darin Adler
Modified: 2021-12-18 17:57 PST (History)
33 users (show)

See Also:


Attachments
Patch (86.24 KB, patch)
2021-12-17 13:54 PST, Darin Adler
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (86.15 KB, patch)
2021-12-17 15:15 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-12-17 11:16:40 PST
Hash tables, read/write, and heap memory are used unnecessarily, which may hurt performance
Comment 1 Darin Adler 2021-12-17 13:54:59 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2021-12-17 15:15:19 PST
Created attachment 447483 [details]
Patch
Comment 3 Darin Adler 2021-12-17 21:11:59 PST
Looks like all the tests are passing so looking for a review
Comment 4 EWS 2021-12-18 15:58:29 PST
Committed r287232 (245392@main): <https://commits.webkit.org/245392@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447483 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-18 15:59:18 PST
<rdar://problem/86675997>
Comment 6 Simon Fraser (smfr) 2021-12-18 17:46:27 PST
Did you just find all these via code inspection, or did you use any tools?
Comment 7 Darin Adler 2021-12-18 17:57:23 PST
This was what I found by just looking around.