Bug 234429 - Update RTCRtpScriptTransformer key frame API according latest spec proposal
Summary: Update RTCRtpScriptTransformer key frame API according latest spec proposal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-17 02:00 PST by youenn fablet
Modified: 2021-12-20 12:44 PST (History)
13 users (show)

See Also:

Attachments
Patch (18.85 KB, patch)
2021-12-17 02:31 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (18.40 KB, patch)
2021-12-17 02:53 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (17.92 KB, patch)
2021-12-20 03:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-12-17 02:00:21 PST 
Update RTCRtpScriptTransformer key frame API according latest spec proposal
Comment 1 youenn fablet 2021-12-17 02:31:51 PST 
Created attachment 447443 [details]
Patch
Comment 2 youenn fablet 2021-12-17 02:53:46 PST 
Created attachment 447445 [details]
Patch
Comment 3 Eric Carlson 2021-12-17 11:05:26 PST 
Comment on attachment 447445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447445&action=review

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:154
> +        fprintf(stderr, "RTCRtpScriptTransformer::generatetKeyFrame promise resolution\n");

You probably don't want to commit this.

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:170
> +    fprintf(stderr, "RTCRtpScriptTransformer::generateKeyFrame2Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h \n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:180
> +    fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest\n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:188
> +    fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest1\n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:193
> +        fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest2\n");

Ditto
Comment 4 youenn fablet 2021-12-20 03:06:25 PST 
Created attachment 447594 [details]
Patch for landing
Comment 5 EWS 2021-12-20 04:40:06 PST 
Committed r287258 (245414@main): <https://commits.webkit.org/245414@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447594 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-20 04:41:18 PST 
<rdar://problem/86719358>