Bug 234424 - Deduplicate code in RenderText::computePreferredLogicalWidths()
Summary: Deduplicate code in RenderText::computePreferredLogicalWidths()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 234421
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-16 21:43 PST by Myles C. Maxfield
Modified: 2021-12-17 14:11 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2021-12-16 21:45 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Depends on bug 234421 (21.50 KB, patch)
2021-12-16 23:03 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Depends on bug 234421 (21.54 KB, patch)
2021-12-16 23:05 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Depends on bug 234421 (21.49 KB, patch)
2021-12-16 23:08 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for EWS (27.50 KB, patch)
2021-12-16 23:08 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for EWS (27.19 KB, patch)
2021-12-16 23:15 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (21.53 KB, patch)
2021-12-17 10:33 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-12-16 21:43:08 PST 
.
Comment 1 Myles C. Maxfield 2021-12-16 21:45:27 PST 
Created attachment 447427 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-16 23:03:44 PST 
Created attachment 447431 [details]
Depends on bug 234421
Comment 3 Myles C. Maxfield 2021-12-16 23:05:20 PST 
Created attachment 447432 [details]
Depends on bug 234421
Comment 4 Myles C. Maxfield 2021-12-16 23:08:20 PST 
Created attachment 447433 [details]
Depends on bug 234421
Comment 5 Myles C. Maxfield 2021-12-16 23:08:57 PST 
Created attachment 447434 [details]
Patch for EWS
Comment 6 Myles C. Maxfield 2021-12-16 23:15:06 PST 
Created attachment 447435 [details]
Patch for EWS
Comment 7 Myles C. Maxfield 2021-12-17 10:33:41 PST 
Created attachment 447460 [details]
Patch
Comment 8 zalan 2021-12-17 12:34:43 PST 
Comment on attachment 447460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review

> Source/WebCore/ChangeLog:31
> +        * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace,

RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either.
Comment 9 Myles C. Maxfield 2021-12-17 13:59:13 PST 
Comment on attachment 447460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review

>> Source/WebCore/ChangeLog:31
>> +        * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace,
> 
> RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either.

Heh, yeah, I didn't even think of that. "Inlines" is the pattern we use in the rest of WebKit, though...
Comment 10 EWS 2021-12-17 14:10:34 PST 
Committed r287206 (245373@main): <https://commits.webkit.org/245373@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447460 [details].
Comment 11 Radar WebKit Bug Importer 2021-12-17 14:11:19 PST 
<rdar://problem/86650129>