RESOLVED FIXED 234424
Deduplicate code in RenderText::computePreferredLogicalWidths() 
https://bugs.webkit.org/show_bug.cgi?id=234424
Summary Deduplicate code in RenderText::computePreferredLogicalWidths()
Myles C. Maxfield
Reported 2021-12-16 21:43:08 PST
.
Attachments
Patch (5.74 KB, patch)
2021-12-16 21:45 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Depends on bug 234421 (21.50 KB, patch)
2021-12-16 23:03 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Depends on bug 234421 (21.54 KB, patch)
2021-12-16 23:05 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Depends on bug 234421 (21.49 KB, patch)
2021-12-16 23:08 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for EWS (27.50 KB, patch)
2021-12-16 23:08 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for EWS (27.19 KB, patch)
2021-12-16 23:15 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (21.53 KB, patch)
2021-12-17 10:33 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-12-16 21:45:27 PST
Created attachment 447427 [details] Patch
Myles C. Maxfield
Comment 2 2021-12-16 23:03:44 PST
Created attachment 447431 [details] Depends on bug 234421
Myles C. Maxfield
Comment 3 2021-12-16 23:05:20 PST
Created attachment 447432 [details] Depends on bug 234421
Myles C. Maxfield
Comment 4 2021-12-16 23:08:20 PST
Created attachment 447433 [details] Depends on bug 234421
Myles C. Maxfield
Comment 5 2021-12-16 23:08:57 PST
Created attachment 447434 [details] Patch for EWS
Myles C. Maxfield
Comment 6 2021-12-16 23:15:06 PST
Created attachment 447435 [details] Patch for EWS
Myles C. Maxfield
Comment 7 2021-12-17 10:33:41 PST
Created attachment 447460 [details] Patch
alan
Comment 8 2021-12-17 12:34:43 PST
Comment on attachment 447460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review > Source/WebCore/ChangeLog:31 > + * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace, RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either.
Myles C. Maxfield
Comment 9 2021-12-17 13:59:13 PST
Comment on attachment 447460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review >> Source/WebCore/ChangeLog:31 >> + * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace, > > RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either. Heh, yeah, I didn't even think of that. "Inlines" is the pattern we use in the rest of WebKit, though...
EWS
Comment 10 2021-12-17 14:10:34 PST
Committed r287206 (245373@main): <https://commits.webkit.org/245373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447460 [details].
Radar WebKit Bug Importer
Comment 11 2021-12-17 14:11:19 PST
<rdar://problem/86650129>
Note You need to log in before you can comment on or make changes to this bug.