Bug 234422 – [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the IsFirstForLayoutBox on the display boxes

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 447422 [details]
Patch

[Antti Koivisto]

Comment on attachment 447422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447422&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458
> +struct FirstLastInlineBoxes {
> +    HashMap<const Box*, size_t> first;
> +    HashMap<const Box*, size_t> last;
> +};

Alternatively a single HashMap with a struct with optional first/last. Might save a hash lookup though maybe it doesn't matter.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 447422 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447422&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458
> > +struct FirstLastInlineBoxes {
> > +    HashMap<const Box*, size_t> first;
> > +    HashMap<const Box*, size_t> last;
> > +};
> 
> Alternatively a single HashMap with a struct with optional first/last. Might
> save a hash lookup though maybe it doesn't matter.
yeah I like that.

[zalan]

Created attachment 447457 [details]
Patch

[EWS]

Committed r287197 (245364@main): <https://commits.webkit.org/245364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447457 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86642161>