Bug 234422 - [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the IsFirstForLayoutBox on the display boxes
Summary: [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the IsFirstForL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-16 21:18 PST by zalan
Modified: 2021-12-17 11:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.36 KB, patch)
2021-12-16 21:25 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.29 KB, patch)
2021-12-17 09:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-16 21:18:57 PST 
ssia
Comment 1 zalan 2021-12-16 21:25:50 PST 
Created attachment 447422 [details]
Patch
Comment 2 Antti Koivisto 2021-12-17 08:00:21 PST 
Comment on attachment 447422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447422&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458
> +struct FirstLastInlineBoxes {
> +    HashMap<const Box*, size_t> first;
> +    HashMap<const Box*, size_t> last;
> +};

Alternatively a single HashMap with a struct with optional first/last. Might save a hash lookup though maybe it doesn't matter.
Comment 3 zalan 2021-12-17 08:04:41 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 447422 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447422&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458
> > +struct FirstLastInlineBoxes {
> > +    HashMap<const Box*, size_t> first;
> > +    HashMap<const Box*, size_t> last;
> > +};
> 
> Alternatively a single HashMap with a struct with optional first/last. Might
> save a hash lookup though maybe it doesn't matter.
yeah I like that.
Comment 4 zalan 2021-12-17 09:50:53 PST 
Created attachment 447457 [details]
Patch
Comment 5 EWS 2021-12-17 11:00:05 PST 
Committed r287197 (245364@main): <https://commits.webkit.org/245364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447457 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-17 11:02:07 PST 
<rdar://problem/86642161>