Bug 234420 - Stub out NotificationEvent and related
Summary: Stub out NotificationEvent and related
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-16 20:46 PST by Brady Eidson
Modified: 2021-12-19 21:05 PST (History)
16 users (show)

See Also:

Attachments
Does it build v1 (34.31 KB, patch)
2021-12-16 20:52 PST, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Does it build v2 (35.30 KB, patch)
2021-12-17 10:14 PST, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Does it build and test v1 (36.82 KB, patch)
2021-12-18 11:51 PST, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Does it build and test v2 (36.82 KB, patch)
2021-12-18 13:33 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 (40.20 KB, patch)
2021-12-18 17:09 PST, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
PFL (40.20 KB, patch)
2021-12-18 21:30 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2021-12-16 20:46:28 PST 
Stub out NotificationEvent and related
Comment 1 Brady Eidson 2021-12-16 20:52:12 PST 
Created attachment 447419 [details]
Does it build v1
Comment 2 Brady Eidson 2021-12-17 10:14:51 PST 
Created attachment 447458 [details]
Does it build v2
Comment 3 Brady Eidson 2021-12-18 11:51:21 PST 
Created attachment 447527 [details]
Does it build and test v1
Comment 4 Brady Eidson 2021-12-18 13:33:04 PST 
Created attachment 447531 [details]
Does it build and test v2
Comment 5 Brady Eidson 2021-12-18 17:09:15 PST 
Created attachment 447537 [details]
Patch v1
Comment 6 Alex Christensen 2021-12-18 18:57:02 PST 
Comment on attachment 447537 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=447537&action=review

> Source/WebCore/Modules/notifications/NotificationEvent.h:58
> +

nit: extra space
Comment 7 Brady Eidson 2021-12-18 21:30:21 PST 
Created attachment 447539 [details]
PFL
Comment 8 EWS 2021-12-19 21:04:44 PST 
Committed r287253 (245411@main): <https://commits.webkit.org/245411@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447539 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-19 21:05:18 PST 
<rdar://problem/86708525>