Bug 23442 - Structure property table deleted offset maps are being leaked.
: Structure property table deleted offset maps are being leaked.
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P1 Normal
Assigned To:
:
: InRadar, ReviewedForRadar
:
:
  Show dependency treegraph
 
Reported: 2009-01-20 17:30 PST by
Modified: 2009-01-20 18:16 PST (History)


Attachments
The patch (1.01 KB, patch)
2009-01-20 17:34 PST, Gavin Barraclough
oliver: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-01-20 17:30:50 PST
Probably shouldn't be doing that.
------- Comment #1 From 2009-01-20 17:34:16 PST -------
Created an attachment (id=26879) [details]
The patch
------- Comment #2 From 2009-01-20 17:52:43 PST -------
(From update of attachment 26879 [details])
r-, i think PropertyMapHashTable::deletedOffsets and m_propertyTable should both just be OwnPtrs so we don't need to explicitly free them
------- Comment #3 From 2009-01-20 17:53:29 PST -------
(From update of attachment 26879 [details])
r=me, i take that back, i see why they're not now
------- Comment #4 From 2009-01-20 17:54:02 PST -------
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/runtime/Structure.cpp
Transmitting file data ..
Committed revision 40076.
------- Comment #5 From 2009-01-20 17:55:09 PST -------
Erm, r=me from bdash in channel, r+ on bug by Oliver... so, reviewed by both!
------- Comment #6 From 2009-01-20 18:16:54 PST -------
<rdar://problem/6503608>