Bug 234396 - Rename forEachFrameFromMainFrame to forEachFrame
Summary: Rename forEachFrameFromMainFrame to forEachFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 23424
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-16 09:54 PST by Brent Fulgham
Modified: 2021-12-16 11:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2021-12-16 10:03 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-12-16 09:54:17 PST 
Follow-up to Bug 234324:

Darin and Simon:
"I agree with Simon: The core functions themselves need not mention the "main frame". They iterate all frames and all documents. The role of the main frame is an unimportant implementation detail that should not be in the function names.

We should immediately rename forEachFrameFromMainFrame to just forEachFrame. The odd function out is forEachDocumentFromMainFrame, and it’s something we should intend to remove (see below)."

This patch does that renaming.
Comment 1 Radar WebKit Bug Importer 2021-12-16 09:55:35 PST 
<rdar://problem/86581926>
Comment 2 Brent Fulgham 2021-12-16 10:03:13 PST 
Created attachment 447367 [details]
Patch
Comment 3 Geoffrey Garen 2021-12-16 10:33:54 PST 
Comment on attachment 447367 [details]
Patch

r=me
Comment 4 EWS 2021-12-16 11:25:00 PST 
Committed r287147 (245330@main): <https://commits.webkit.org/245330@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447367 [details].