Bug 234373 – [css-values-4] logical `*vi`(inline) and `*vb` (block) viewport units should be based on the current element's `writing-mode`

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Devin Rousso]

from https://github.com/w3c/csswg-drafts/issues/6873#issuecomment-995093243
> RESOLVED: Writing-mode sensitive viewport units (and analogous units) use the writing mode of the element they're used on.

[Devin Rousso]

Created attachment 447303 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 447303 [details]
Patch

WPT?

[Radar WebKit Bug Importer]

<rdar://problem/86832561>

[Tim Nguyen (:ntim)]

Comment on attachment 447303 [details]
Patch

What Simon said :)

[Tim Nguyen (:ntim)]

Also stylebot doesn't look happy

[Sam Sneddon [:gsnedders]]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 447303 [details]
> Patch
> 
> WPT?

/css/css-values/viewport-units-writing-mode.html covers this now (though didn't exist when you wrote that comment!)

[Tim Nguyen (:ntim)]

(In reply to Sam Sneddon [:gsnedders] from comment #6)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 447303 [details]
> > Patch
> > 
> > WPT?
> 
> /css/css-values/viewport-units-writing-mode.html covers this now (though
> didn't exist when you wrote that comment!)

Let's import them! :)

[Devin Rousso]

Pull request: https://github.com/WebKit/WebKit/pull/863

[EWS]

Committed r294609 (250835@main): <https://commits.webkit.org/250835@main>

Reviewed commits have been landed. Closing PR #863 and removing active labels.