Bug 234373 - [css-values-4] logical `*vi`(inline) and `*vb` (block) viewport units should be based on the current element's `writing-mode`
Summary: [css-values-4] logical `*vi`(inline) and `*vb` (block) viewport units should ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 232895
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-15 17:39 PST by Devin Rousso
Modified: 2022-05-20 22:40 PDT (History)
13 users (show)

See Also:

Attachments
Patch (59.81 KB, patch)
2021-12-15 17:47 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-12-15 17:39:47 PST 
from https://github.com/w3c/csswg-drafts/issues/6873#issuecomment-995093243
> RESOLVED: Writing-mode sensitive viewport units (and analogous units) use the writing mode of the element they're used on.
Comment 1 Devin Rousso 2021-12-15 17:47:24 PST 
Created attachment 447303 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-12-15 20:55:23 PST 
Comment on attachment 447303 [details]
Patch

WPT?
Comment 3 Radar WebKit Bug Importer 2021-12-22 17:40:16 PST 
<rdar://problem/86832561>
Comment 4 Tim Nguyen (:ntim) 2022-02-27 00:20:15 PST 
Comment on attachment 447303 [details]
Patch

What Simon said :)
Comment 5 Tim Nguyen (:ntim) 2022-02-27 00:20:47 PST 
Also stylebot doesn't look happy
Comment 6 Sam Sneddon [:gsnedders] 2022-04-18 18:24:41 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 447303 [details]
> Patch
> 
> WPT?

/css/css-values/viewport-units-writing-mode.html covers this now (though didn't exist when you wrote that comment!)
Comment 7 Tim Nguyen (:ntim) 2022-04-28 08:48:02 PDT 
(In reply to Sam Sneddon [:gsnedders] from comment #6)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 447303 [details]
> > Patch
> > 
> > WPT?
> 
> /css/css-values/viewport-units-writing-mode.html covers this now (though
> didn't exist when you wrote that comment!)

Let's import them! :)
Comment 8 Devin Rousso 2022-05-20 15:02:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/863
Comment 9 EWS 2022-05-20 22:40:37 PDT 
Committed r294609 (250835@main): <https://commits.webkit.org/250835@main>

Reviewed commits have been landed. Closing PR #863 and removing active labels.