RESOLVED FIXED234372
Some webpushtool improvements 
https://bugs.webkit.org/show_bug.cgi?id=234372
Summary Some webpushtool improvements
Brady Eidson
Reported 2021-12-15 16:21:07 PST
Some webpushtool improvements
Attachments
Patch v1 (7.19 KB, patch)
2021-12-15 18:55 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2021-12-15 18:55:23 PST
Created attachment 447311 [details] Patch v1
Alex Christensen
Comment 2 2021-12-15 19:05:58 PST
Comment on attachment 447311 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=447311&action=review > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153 > + CFRunLoopStop(CFRunLoopGetMain()); exit(0)?
Brady Eidson
Comment 3 2021-12-15 19:32:51 PST
(In reply to Alex Christensen from comment #2) > Comment on attachment 447311 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447311&action=review > > > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153 > > + CFRunLoopStop(CFRunLoopGetMain()); > > exit(0)? I have future vision for the next enhancement that'll involve a nested runloop 😆
EWS
Comment 4 2021-12-15 20:34:48 PST
Committed r287125 (245309@main): <https://commits.webkit.org/245309@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447311 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-15 20:35:19 PST
<rdar://problem/86556476>
Note You need to log in before you can comment on or make changes to this bug.