Bug 234372 - Some webpushtool improvements
Summary: Some webpushtool improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-15 16:21 PST by Brady Eidson
Modified: 2021-12-15 20:35 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (7.19 KB, patch)
2021-12-15 18:55 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2021-12-15 16:21:07 PST 
Some webpushtool improvements
Comment 1 Brady Eidson 2021-12-15 18:55:23 PST 
Created attachment 447311 [details]
Patch v1
Comment 2 Alex Christensen 2021-12-15 19:05:58 PST 
Comment on attachment 447311 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=447311&action=review

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153
> +            CFRunLoopStop(CFRunLoopGetMain());

exit(0)?
Comment 3 Brady Eidson 2021-12-15 19:32:51 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 447311 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447311&action=review
> 
> > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153
> > +            CFRunLoopStop(CFRunLoopGetMain());
> 
> exit(0)?

I have future vision for the next enhancement that'll involve a nested runloop 😆
Comment 4 EWS 2021-12-15 20:34:48 PST 
Committed r287125 (245309@main): <https://commits.webkit.org/245309@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447311 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-15 20:35:19 PST 
<rdar://problem/86556476>