Bug 234369 - Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree
Summary: Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScro...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-15 15:29 PST by Simon Fraser (smfr)
Modified: 2021-12-22 15:30 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.48 KB, patch)
2021-12-15 15:30 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-12-15 15:29:15 PST 
Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree
Comment 1 Simon Fraser (smfr) 2021-12-15 15:30:31 PST 
Created attachment 447291 [details]
Patch
Comment 2 Sam Weinig 2021-12-16 12:36:56 PST 
Comment on attachment 447291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447291&action=review

> Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:118
> +#if PLATFORM(COCOA)
> +        platformWheelEvent = scrollingTree->wheelEventAfterFiltering(platformWheelEvent);
> +#endif

Can we have all platforms implement wheelEventAfterFiltering() (or the base class) as the identity function if they don't need to do any filtering to remove this #ifdef?
Comment 3 Radar WebKit Bug Importer 2021-12-22 15:30:18 PST 
<rdar://problem/86828138>