Bug 234367 – Use arm64's fmax/fmin instructions in Wasm

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 447383 [details]
patch

[EWS Watchlist]

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

[Keith Miller]

Comment on attachment 447383 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447383&action=review

R=me with nit

> Source/JavaScriptCore/b3/B3Common.h:163
> +        return a + b;

nit: Why not just return PNaN? This makes me think I forgot how adding nans work lol.

[Keith Miller]

Comment on attachment 447383 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447383&action=review

R=me with nit

> Source/JavaScriptCore/b3/B3Common.h:163
> +        return a + b;

nit: Why not just return PNaN? This makes me think I forgot how adding nans work lol.

[Saam Barati]

Comment on attachment 447383 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447383&action=review

>>> Source/JavaScriptCore/b3/B3Common.h:163
>>> +        return a + b;
>> 
>> nit: Why not just return PNaN? This makes me think I forgot how adding nans work lol.
> 
> nit: Why not just return PNaN? This makes me think I forgot how adding nans work lol.

I’m just copying what we do at runtime on x86 in the generated code so hopefully the bits might stay the same even if not guaranteed or required to.

[EWS]

Committed r287160 (245337@main): <https://commits.webkit.org/245337@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447383 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86608449>