Bug 234355 – Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.

[Radar WebKit Bug Importer]

<rdar://problem/86532703>

[Andres Gonzalez]

Created attachment 447261 [details]
Patch

[chris fleizach]

Comment on attachment 447261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447261&action=review

> Source/WebCore/ChangeLog:10
> +

extra new line

[Andres Gonzalez]

Created attachment 447316 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #3)
> Comment on attachment 447261 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447261&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +
> 
> extra new line

Fixed.

Also found another instance of this problem with m_passwordNotificationsToPost.

[EWS]

Committed r287139 (245323@main): <https://commits.webkit.org/245323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447316 [details].

[Darin Adler]

Comment on attachment 447316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447316&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1085
>      auto notifications = WTFMove(m_notificationsToPost);
> +    m_notificationsToPost.clear();

The best idiom for this sort of thing is:

    auto notifications = std::exchange(m_notificationsToPost, { });

[Andres Gonzalez]

(In reply to Darin Adler from comment #7)
> Comment on attachment 447316 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447316&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1085
> >      auto notifications = WTFMove(m_notificationsToPost);
> > +    m_notificationsToPost.clear();
> 
> The best idiom for this sort of thing is:
> 
>     auto notifications = std::exchange(m_notificationsToPost, { });

Thanks, corrected in https://bugs.webkit.org/show_bug.cgi?id=234919.