Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.
<rdar://problem/86532703>
Created attachment 447261 [details] Patch
Comment on attachment 447261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447261&action=review > Source/WebCore/ChangeLog:10 > + extra new line
Created attachment 447316 [details] Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 447261 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447261&action=review > > > Source/WebCore/ChangeLog:10 > > + > > extra new line Fixed. Also found another instance of this problem with m_passwordNotificationsToPost.
Committed r287139 (245323@main): <https://commits.webkit.org/245323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447316 [details].
Comment on attachment 447316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447316&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > auto notifications = WTFMove(m_notificationsToPost); > + m_notificationsToPost.clear(); The best idiom for this sort of thing is: auto notifications = std::exchange(m_notificationsToPost, { });
(In reply to Darin Adler from comment #7) > Comment on attachment 447316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447316&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > > auto notifications = WTFMove(m_notificationsToPost); > > + m_notificationsToPost.clear(); > > The best idiom for this sort of thing is: > > auto notifications = std::exchange(m_notificationsToPost, { }); Thanks, corrected in https://bugs.webkit.org/show_bug.cgi?id=234919.