WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234354
More cleanup after PluginProcess removal
https://bugs.webkit.org/show_bug.cgi?id=234354
Summary
More cleanup after PluginProcess removal
Alex Christensen
Reported
2021-12-15 10:40:00 PST
More cleanup after PluginProcess removal
Attachments
Patch
(64.84 KB, patch)
2021-12-15 10:41 PST
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2021-12-15 10:41:42 PST
Created
attachment 447255
[details]
Patch
Tim Horton
Comment 2
2021-12-15 11:39:52 PST
Comment on
attachment 447255
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=447255&action=review
> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-398 > - 3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };
Certainly not strictly necessary, why are you shrinking!
> Source/WebKit/WebKit.xcodeproj/project.pbxproj:830 > + 3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };
I think you need to do some sort-xcode-project-whatever
Alex Christensen
Comment 3
2021-12-15 11:42:21 PST
Comment on
attachment 447255
[details]
Patch This is what Xcode did. It sorts that section by the "5CAECB6627465AE400AB78D0" not by the "UnifiedSource115.cpp"
EWS
Comment 4
2021-12-15 11:59:06 PST
Committed
r287093
(
245285@main
): <
https://commits.webkit.org/245285@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 447255
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-12-15 12:00:32 PST
<
rdar://problem/86535824
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug