Bug 234354 - More cleanup after PluginProcess removal
Summary: More cleanup after PluginProcess removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 237555
  Show dependency tree / graph
 
Reported: 2021-12-15 10:40 PST by Alex Christensen
Modified: 2022-03-07 14:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (64.84 KB, patch)
2021-12-15 10:41 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-12-15 10:40:00 PST 
More cleanup after PluginProcess removal
Comment 1 Alex Christensen 2021-12-15 10:41:42 PST 
Created attachment 447255 [details]
Patch
Comment 2 Tim Horton 2021-12-15 11:39:52 PST 
Comment on attachment 447255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447255&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-398
> -		3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };

Certainly not strictly necessary, why are you shrinking!

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:830
> +		3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };

I think you need to do some sort-xcode-project-whatever
Comment 3 Alex Christensen 2021-12-15 11:42:21 PST 
Comment on attachment 447255 [details]
Patch

This is what Xcode did.  It sorts that section by the "5CAECB6627465AE400AB78D0" not by the "UnifiedSource115.cpp"
Comment 4 EWS 2021-12-15 11:59:06 PST 
Committed r287093 (245285@main): <https://commits.webkit.org/245285@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447255 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-15 12:00:32 PST 
<rdar://problem/86535824>