Bug 234352 - REGRESSION(r284368) [GStreamer] Image tests often don't render the player
Summary: REGRESSION(r284368) [GStreamer] Image tests often don't render the player
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-15 10:00 PST by Arcady Goldmints-Orlov
Modified: 2023-03-27 06:23 PDT (History)
15 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2021-12-17 07:51 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-12-15 10:00:56 PST
The test imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html has started failing as of r284368. The test does some XHR requests to get a video file that just shows a static blue rectangle, but after the revision in question, the expected blue square is not visible anymore.
Comment 1 Philippe Normand 2021-12-17 07:51:18 PST
Created attachment 447456 [details]
Patch
Comment 2 EWS 2021-12-22 00:46:01 PST
Committed r287349 (245491@main): <https://commits.webkit.org/245491@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447456 [details].
Comment 3 Radar WebKit Bug Importer 2021-12-22 00:47:15 PST
<rdar://problem/86801637>
Comment 4 Arcady Goldmints-Orlov 2021-12-22 11:00:25 PST
Sadly this test still fails. The video is visible now, there is a blue square as expected but the actual blue square is the color #0100ff and what the test wants is #0000ff. So close.
Comment 5 Philippe Normand 2021-12-22 11:34:09 PST
It was passing when I submitted the patch but I haven't checked since then. Maybe some of the recent changes around colorspace handling broke it again. Please open a new bug or rebaseline accordingly :)
Comment 6 Philippe Normand 2021-12-22 12:02:16 PST
Reverting r287323 gets me a blu^Wgreen test again, fwiw. Maybe this should be flagged as a fuzzy test.
Comment 7 Alicia Boya García 2023-03-27 06:14:39 PDT
r260879 (2023-02-27) was the last build in the bots where this passed in GTK. It has been failing in Release since, while mostly passing in Debug.
Comment 8 Alicia Boya García 2023-03-27 06:20:32 PDT
(In reply to Alicia Boya García from comment #7)
> r260879 (2023-02-27) was the last build in the bots where this passed in
> GTK. It has been failing in Release since, while mostly passing in Debug.

Wrong revision due to repo changes... Anyway.

I've noticed this is a problem with more tests. It seems that the test runner fails to capture video image in the GStreamer ports:

imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html
media/media-source/media-source-video-renders.html
media/track/track-webvtt-no-snap-to-lines-overlap.html
media/track/track-webvtt-snap-to-lines-inline-style.html
media/track/track-webvtt-snap-to-lines-left-right.html
media/video-with-alpha.html
Comment 9 Philippe Normand 2023-03-27 06:23:15 PDT
That's https://bugs.webkit.org/show_bug.cgi?id=244727