RESOLVED FIXED 234339
Make use of PLATFORM(COCOA) in MediaRecorder WebPreference 
https://bugs.webkit.org/show_bug.cgi?id=234339
Summary Make use of PLATFORM(COCOA) in MediaRecorder WebPreference
youenn fablet
Reported 2021-12-15 02:04:01 PST
Make use of HAVE(AVASSETWRITERDELEGATE_API) in MediaRecorder WebPreference
Attachments
Patch (1.50 KB, patch)
2021-12-15 02:16 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.53 KB, patch)
2021-12-15 05:47 PST, youenn fablet 		youennf: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-12-15 02:15:33 PST
<rdar://85432071>
youenn fablet
Comment 2 2021-12-15 02:16:08 PST
Created attachment 447211 [details] Patch
youenn fablet
Comment 3 2021-12-15 02:17:09 PST
It is very easy to fall into that disable-feature trap. It seems we should be able to catch these bugs earlier though.
Eric Carlson
Comment 4 2021-12-15 05:26:51 PST
Comment on attachment 447211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447211&action=review > Source/WTF/ChangeLog:11 > + Llet's guard MediaRecorder with PLATFORM(COCOA). s/Llet's/Let's/
youenn fablet
Comment 5 2021-12-15 05:47:39 PST
Created attachment 447226 [details] Patch for landing
EWS
Comment 6 2021-12-15 06:41:56 PST
Committed r287072 (245267@main): <https://commits.webkit.org/245267@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447226 [details].
Eric Carlson
Comment 7 2021-12-15 08:24:35 PST
Caused by r283431
Note You need to log in before you can comment on or make changes to this bug.