Bug 234332 – [GTK][WPE] Build fix for Debian Stable after r287015

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GTK][WPE] Build fix for Debian Stable after r287015

[Diego Pino]

Created attachment 447192 [details]
Patch

[Diego Pino]

Debian Stable build bot started failing r287015:

  https://build.webkit.org/#/builders/46

Compilation error was:

```
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-cbdfe323-30.cpp:8:
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In constructor ‘WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)::KeyInfo::KeyInfo()’:
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:129:12: error: char-array initialized from wide string
     struct KeyInfo {
            ^~~~~~~
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In function ‘std::optional<WTF::Vector<unsigned char> > WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)’:
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:137:13: note: synthesized method ‘WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)::KeyInfo::KeyInfo()’ first required here
     KeyInfo keyInfo;
             ^~~~~~~
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In constructor ‘WebCore::PushCrypto::decryptAESGCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>, WTF::Span<const unsigned char, 18446744073709551615>, WTF::Span<const unsigned char, 18446744073709551615>)::KeyDerivationContext::KeyDerivationContext()’:
../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:253:12: error: char-array initialized from wide string
     struct KeyDerivationContext {
            ^~~~~~~~~~~~~~~~~~~~
```

The bot uses GCC 8.3:

```
$ gcc --version
gcc (Debian 8.3.0-6) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

[Diego Pino]

Created attachment 447193 [details]
Patch

[Ben Nham]

Seems fine to me but I'm not a reviewer. I'll ping someone on the team to give the r+.

[EWS]

Committed r287065 (245260@main): <https://commits.webkit.org/245260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447193 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86511377>