Bug 234320 - Add client layer plumbing for classifying modal container controls
Summary: Add client layer plumbing for classifying modal container controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-14 15:43 PST by Wenson Hsieh
Modified: 2021-12-19 12:45 PST (History)
13 users (show)

See Also:

Attachments
Patch (21.78 KB, patch)
2021-12-17 12:11 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (21.91 KB, patch)
2021-12-18 11:35 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix ChangeLog (21.77 KB, patch)
2021-12-18 11:37 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Add missing WTFMove() (21.78 KB, patch)
2021-12-18 15:56 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (21.79 KB, patch)
2021-12-19 11:35 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-12-14 15:43:20 PST 
.
Comment 1 Wenson Hsieh 2021-12-17 12:11:25 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-18 11:35:01 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-12-18 11:37:42 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2021-12-18 15:56:34 PST 
Created attachment 447534 [details]
Add missing WTFMove()
Comment 5 Wenson Hsieh 2021-12-19 11:28:47 PST 
Comment on attachment 447534 [details]
Add missing WTFMove()

View in context: https://bugs.webkit.org/attachment.cgi?id=447534&action=review

Thanks for the review!

> Source/WebCore/page/ChromeClient.h:147
> +enum class ModalContainerControlType : uint8_t;

(I'll keep this sorted in alphabetical order before landing)
Comment 6 Wenson Hsieh 2021-12-19 11:35:00 PST 
Created attachment 447552 [details]
Patch for landing
Comment 7 EWS 2021-12-19 12:44:45 PST 
Committed r287247 (245405@main): <https://commits.webkit.org/245405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447552 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-19 12:45:20 PST 
<rdar://problem/86697812>