WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
234318
Display list iteration should automatically stop if an item is null
https://bugs.webkit.org/show_bug.cgi?id=234318
Summary
Display list iteration should automatically stop if an item is null
Gabriel Nava Marino
Reported
2021-12-14 15:26:49 PST
We should consider modifying DisplayList::Iterator::operator== so display list iteration automatically stops iterating if an item is null. As was previously recommended, this can be done by making DisplayList::Iterator::operator== return true when called with a null iterator and the end iterator by changing ``` bool operator==(const Iterator& other) const { return &m_displayList == &other.m_displayList && m_cursor == other.m_cursor; } ``` to ``` bool operator==(const Iterator& other) const { if (atEnd() && other.atEnd()) return true; return &m_displayList == &other.m_displayList && m_cursor == other.m_cursor; } ``` This requires updating the following two API tests: - TestWebKitAPI.DisplayListTests.InlineItemValidationFailure - TestWebKitAPI.DisplayListTests.OutOfLineItemDecodingFailure
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-12-21 15:27:16 PST
<
rdar://problem/86786410
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug