Bug 234316 - [JSC] OpInstanceofCustom should be in CommonSlowPaths
Summary: [JSC] OpInstanceofCustom should be in CommonSlowPaths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-14 14:17 PST by Ross Kirsling
Modified: 2021-12-14 17:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (10.61 KB, patch)
2021-12-14 14:23 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-12-14 14:17:50 PST 
[JSC] OpInstanceofCustom should be in CommonSlowPaths
Comment 1 Ross Kirsling 2021-12-14 14:23:54 PST 
Created attachment 447161 [details]
Patch
Comment 2 Alexey Shvayka 2021-12-14 15:38:14 PST 
Comment on attachment 447161 [details]
Patch

This change looks good since Symbol.hasInstance hasn't get much usage on the web, and it will also simplify https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get thoroughly benchmarked and reviewed during / right after the 🎄 break.

r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the instanceof-bound.js, which takes this path).
Comment 3 Ross Kirsling 2021-12-14 16:41:08 PST 
Comment on attachment 447161 [details]
Patch

(In reply to Alexey Shvayka from comment #2)
> Comment on attachment 447161 [details]
> Patch
> 
> This change looks good since Symbol.hasInstance hasn't get much usage on the
> web, and it will also simplify
> https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get
> thoroughly benchmarked and reviewed during / right after the 🎄 break.
> 
> r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the
> instanceof-bound.js, which takes this path).

Thanks, sounds great! The results indeed seem neutral.
Comment 4 EWS 2021-12-14 17:24:56 PST 
Committed r287058 (245254@main): <https://commits.webkit.org/245254@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447161 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-14 17:25:18 PST 
<rdar://problem/86498327>