Bug 234310 - Split ATK specific code in WPEViewBackends
Summary: Split ATK specific code in WPEViewBackends
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-14 13:45 PST by Don Olmstead
Modified: 2021-12-15 13:33 PST (History)
8 users (show)

See Also:

Attachments
WIP Patch (13.82 KB, patch)
2021-12-14 13:52 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (13.82 KB, patch)
2021-12-14 13:58 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (14.90 KB, patch)
2021-12-14 14:58 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (14.97 KB, patch)
2021-12-14 16:19 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (16.76 KB, patch)
2021-12-14 22:27 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.20 KB, patch)
2021-12-14 22:31 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-12-14 13:45:27 PST 
...
Comment 1 Don Olmstead 2021-12-14 13:52:21 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-12-14 13:58:01 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-12-14 14:58:50 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-12-14 16:19:28 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2021-12-14 22:27:23 PST Comment hidden (obsolete)
Comment 6 Don Olmstead 2021-12-14 22:31:30 PST 
Created attachment 447205 [details]
Patch
Comment 7 Michael Catanzaro 2021-12-15 08:13:26 PST 
Comment on attachment 447205 [details]
Patch

This looks fine to me, but I'll let a WPE port maintainer give the final r+.

The other way to do it would be to create Tools/wpe/backends/wpe/ViewBackendWPE.cpp as the "WPE port version of the WPE ViewBackend" so that it can contain WPE port-specific stuff separate from the generic libwpe stuff, which might be more typical for us and could include more than just ATK dependencies. But maybe that's just too confusing. :)
Comment 8 EWS 2021-12-15 13:33:29 PST 
Committed r287105 (245294@main): <https://commits.webkit.org/245294@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447205 [details].