Bug 23430 – Frame Refactor: Move methods from Frame to Editor

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit Misc.

[Holger Freyther]

const Selection& mark() const; // Mark, to be used as emacs uses it.
void setMark(const Selection&);

void computeAndSetTypingStyle(CSSStyleDeclaration* , EditAction = EditActionUnspecified);
String selectionStartStylePropertyValue(int stylePropertyID) const;
void applyEditingStyleToBodyElement() const;
void applyEditingStyleToElement(Element*) const;

IntRect firstRectForRange(Range*) const;

void respondToChangedSelection(const Selection& oldSelection, bool closeTyping);
bool shouldChangeSelection(const Selection& oldSelection, const Selection& newSelection, EAffinity, bool stillSelecting) const;

RenderStyle* styleForSelectionStart(Node*& nodeToRemove) const;

unsigned markAllMatchesForText(const String&, bool caseFlag, unsigned limit);
bool markedTextMatchesAreHighlighted() const;
void setMarkedTextMatchesAreHighlighted(bool flag);

PassRefPtr<CSSComputedStyleDeclaration> selectionComputedStyle(Node*& nodeToRemove) const;

void textFieldDidBeginEditing(Element*);
void textFieldDidEndEditing(Element*);
void textDidChangeInTextField(Element*);
bool doTextFieldCommandFromEvent(Element*, KeyboardEvent*);
void textWillBeDeletedInTextField(Element* input);
void textDidChangeInTextArea(Element*);

DragImageRef dragImageForSelection();

[Holger Freyther]

Created attachment 26862 [details]
Do the moving

Tests pass on the mac. I need to verify the result o git rebase and manual merging as I was hit hard by Sam's work on killing FramePrivate. Review and comments are appreciated right now.

[Eric Seidel (no email)]

Comment on attachment 26862 [details]
Do the moving

So long as you're just moving code, this looks great.  I worry that this patch is long-since rotten (that the methods you're moving may have changed).

It seems a little strange that selectedText() is on Editor instead of say SelectionController, but it seems fine.

r=me, if you make sure the patch is updated to compile with TOT with all the LayoutTests passing and that you're certain that the code you are moving is up-to-date.

[Eric Seidel (no email)]

Comment on attachment 26862 [details]
Do the moving

Not much use having this in the commit queue.  You have my r+ if this is updated to work on TOT.  I guess I'll mark it r- for now and you can re-post a patch which applies on TOT.

[Ryosuke Niwa]

Fixed in http://trac.webkit.org/changeset/67122.

*** This bug has been marked as a duplicate of bug 45218 ***