Bug 23430 - Frame Refactor: Move methods from Frame to Editor
Summary: Frame Refactor: Move methods from Frame to Editor
Status: RESOLVED DUPLICATE of bug 45218
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Holger Freyther
Depends on:
Reported: 2009-01-20 03:58 PST by Holger Freyther
Modified: 2012-05-30 00:54 PDT (History)
1 user (show)

See Also:

Do the moving (86.95 KB, patch)
2009-01-20 04:43 PST, Holger Freyther
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-01-20 03:58:53 PST
const Selection& mark() const; // Mark, to be used as emacs uses it.
void setMark(const Selection&);

void computeAndSetTypingStyle(CSSStyleDeclaration* , EditAction = EditActionUnspecified);
String selectionStartStylePropertyValue(int stylePropertyID) const;
void applyEditingStyleToBodyElement() const;
void applyEditingStyleToElement(Element*) const;

IntRect firstRectForRange(Range*) const;

void respondToChangedSelection(const Selection& oldSelection, bool closeTyping);
bool shouldChangeSelection(const Selection& oldSelection, const Selection& newSelection, EAffinity, bool stillSelecting) const;

RenderStyle* styleForSelectionStart(Node*& nodeToRemove) const;

unsigned markAllMatchesForText(const String&, bool caseFlag, unsigned limit);
bool markedTextMatchesAreHighlighted() const;
void setMarkedTextMatchesAreHighlighted(bool flag);

PassRefPtr<CSSComputedStyleDeclaration> selectionComputedStyle(Node*& nodeToRemove) const;

void textFieldDidBeginEditing(Element*);
void textFieldDidEndEditing(Element*);
void textDidChangeInTextField(Element*);
bool doTextFieldCommandFromEvent(Element*, KeyboardEvent*);
void textWillBeDeletedInTextField(Element* input);
void textDidChangeInTextArea(Element*);

DragImageRef dragImageForSelection();
Comment 1 Holger Freyther 2009-01-20 04:43:30 PST
Created attachment 26862 [details]
Do the moving

Tests pass on the mac. I need to verify the result o git rebase and manual merging as I was hit hard by Sam's work on killing FramePrivate. Review and comments are appreciated right now.
Comment 2 Eric Seidel (no email) 2009-05-21 18:32:55 PDT
Comment on attachment 26862 [details]
Do the moving

So long as you're just moving code, this looks great.  I worry that this patch is long-since rotten (that the methods you're moving may have changed).

It seems a little strange that selectedText() is on Editor instead of say SelectionController, but it seems fine.

r=me, if you make sure the patch is updated to compile with TOT with all the LayoutTests passing and that you're certain that the code you are moving is up-to-date.
Comment 3 Eric Seidel (no email) 2009-06-15 18:57:08 PDT
Comment on attachment 26862 [details]
Do the moving

Not much use having this in the commit queue.  You have my r+ if this is updated to work on TOT.  I guess I'll mark it r- for now and you can re-post a patch which applies on TOT.
Comment 4 Ryosuke Niwa 2012-05-30 00:54:10 PDT
Fixed in http://trac.webkit.org/changeset/67122.

*** This bug has been marked as a duplicate of bug 45218 ***