Bug 234264 - Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList()
Summary: Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemory...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabriel Nava Marino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-13 13:34 PST by Gabriel Nava Marino
Modified: 2021-12-14 14:17 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2021-12-13 13:39 PST, Gabriel Nava Marino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2021-12-13 13:34:37 PST 
We need to breakout out of iteration if the item is nullopt.
Comment 1 Gabriel Nava Marino 2021-12-13 13:35:17 PST 
<rdar://problem/86152753>
Comment 2 Gabriel Nava Marino 2021-12-13 13:39:37 PST 
Created attachment 447054 [details]
Patch
Comment 3 Myles C. Maxfield 2021-12-14 14:08:11 PST 
Comment on attachment 447054 [details]
Patch

We should consider modifying DisplayList::Iterator::operator== to see if this behavior can automatically occur for all display list iteration. This is fine for now, though.
Comment 4 EWS 2021-12-14 14:17:05 PST 
Committed r287048 (245245@main): <https://commits.webkit.org/245245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447054 [details].