WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234264
Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList()
https://bugs.webkit.org/show_bug.cgi?id=234264
Summary
Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemory...
Gabriel Nava Marino
Reported
2021-12-13 13:34:37 PST
We need to breakout out of iteration if the item is nullopt.
Attachments
Patch
(1.81 KB, patch)
2021-12-13 13:39 PST
,
Gabriel Nava Marino
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gabriel Nava Marino
Comment 1
2021-12-13 13:35:17 PST
<
rdar://problem/86152753
>
Gabriel Nava Marino
Comment 2
2021-12-13 13:39:37 PST
Created
attachment 447054
[details]
Patch
Myles C. Maxfield
Comment 3
2021-12-14 14:08:11 PST
Comment on
attachment 447054
[details]
Patch We should consider modifying DisplayList::Iterator::operator== to see if this behavior can automatically occur for all display list iteration. This is fine for now, though.
EWS
Comment 4
2021-12-14 14:17:05 PST
Committed
r287048
(
245245@main
): <
https://commits.webkit.org/245245@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 447054
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug