RESOLVED FIXED 23426
Frame Refactor: Move isFrameSet to Document 
https://bugs.webkit.org/show_bug.cgi?id=23426
Summary Frame Refactor: Move isFrameSet to Document
Holger Freyther
Reported 2009-01-20 03:52:08 PST
Move isFrameSet to Document as commented in Frame.h.
Attachments
Carry out the move (7.26 KB, patch)
2009-01-20 04:35 PST, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Make isFrameSet virtual (2.64 KB, patch)
2009-01-30 19:23 PST, Holger Freyther 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2009-01-20 04:35:40 PST
Created attachment 26856 [details] Carry out the move I think the added null check (if correct) looks ugly and it would be a case for leaving isFrameSet in Frame. Test cases pass on the mac.
Darin Adler
Comment 2 2009-01-23 14:18:32 PST
Comment on attachment 26856 [details] Carry out the move > +bool Document::isFrameSet() const > +{ > + if (!isHTMLDocument()) > + return false; This should be a virtual function, then, and be overridden in HTMLDocument. That wasn't possible before when this was a function on Frame. I'll say r=me, but it would be better to do it that way
Holger Freyther
Comment 3 2009-01-30 19:23:23 PST
Created attachment 27209 [details] Make isFrameSet virtual Take Darin's comment into account and make isFrameSet virtual. Reimplement it in HTMLDocument (this patch is not tested).
Holger Freyther
Comment 4 2009-01-30 19:52:20 PST
Comment on attachment 26856 [details] Carry out the move Landed in r40443, leaving this bug open due the new patch.
Sam Weinig
Comment 5 2009-02-03 13:06:45 PST
Comment on attachment 27209 [details] Make isFrameSet virtual r=me > +bool HTMLDocument::isFrameSet() const > +{ > + HTMLElement *bodyElement = body(); * should be on the other side.
Holger Freyther
Comment 6 2009-02-04 05:40:46 PST
Closing it. The style fix was included.
Note You need to log in before you can comment on or make changes to this bug.