Bug 234253 - Regression(r283565) Unable to report private messages as Spam in Twitter app
Summary: Regression(r283565) Unable to report private messages as Spam in Twitter app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 230935
  Show dependency tree / graph
 
Reported: 2021-12-13 10:25 PST by Chris Dumez
Modified: 2021-12-13 15:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2021-12-13 10:31 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-12-13 10:25:27 PST 
Unable to report private messages as Spam in Twitter app since r283565.
Comment 1 Chris Dumez 2021-12-13 10:25:37 PST 
<rdar://86043227>
Comment 2 Chris Dumez 2021-12-13 10:31:23 PST 
Created attachment 447025 [details]
Patch
Comment 3 Alex Christensen 2021-12-13 10:33:51 PST 
Comment on attachment 447025 [details]
Patch

The original change also changed ResourceHandle.  Should we add the linked-on-or-after checks there too?
Comment 4 Chris Dumez 2021-12-13 10:34:45 PST 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 447025 [details]
> Patch
> 
> The original change also changed ResourceHandle.  Should we add the
> linked-on-or-after checks there too?

I'd be tempted to wait until we get a report of breakage in iOS wk1. What do you think?
Comment 5 Alex Christensen 2021-12-13 10:35:38 PST 
Comment on attachment 447025 [details]
Patch

I'm not sure.  You make the call.
Comment 6 Geoffrey Garen 2021-12-13 10:38:21 PST 
r=me

Does this workflow work in the browser? Seems like it would be broken everywhere if the server were broken.
Comment 7 Chris Dumez 2021-12-13 10:43:42 PST 
(In reply to Geoffrey Garen from comment #6)
> r=me
> 
> Does this workflow work in the browser? Seems like it would be broken
> everywhere if the server were broken.

I wasn't able to reproduce the issue in browser, only in the Twitter app.
Comment 8 EWS 2021-12-13 12:31:19 PST 
Committed r286971 (245193@main): <https://commits.webkit.org/245193@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447025 [details].
Comment 9 Chris Dumez 2021-12-13 15:01:54 PST 
Follow-up build fix in <https://commits.webkit.org/r286986>.