Bug 234244 - [css-flexbox] Absolutely positioned children should be aligned using the margin box
Summary: [css-flexbox] Absolutely positioned children should be aligned using the marg...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-13 08:49 PST by Sergio Villar Senin
Modified: 2021-12-15 01:05 PST (History)
12 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2021-12-13 08:54 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2021-12-14 01:59 PST, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-12-13 08:49:21 PST 
[css-flexbox] Absolutely positioned children should be aligned using the margin box
Comment 1 Sergio Villar Senin 2021-12-13 08:54:04 PST 
Created attachment 447009 [details]
Patch
Comment 2 Vitaly Dyachkov 2021-12-13 09:45:04 PST 
Comment on attachment 447009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447009&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1687
> +    auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child);

availableAlignmentSpaceForChild() method contains an assertion: ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a positioned child?
Comment 3 Sergio Villar Senin 2021-12-13 15:06:05 PST 
(In reply to Vitaly Dyachkov from comment #2)
> Comment on attachment 447009 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447009&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:1687
> > +    auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child);
> 
> availableAlignmentSpaceForChild() method contains an assertion:
> ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a
> positioned child?

Right, that's why EWS are complaining. I'll review tomorrow why that assert was added, looks like it does not make much sense.
Comment 4 Sergio Villar Senin 2021-12-14 01:59:48 PST 
Created attachment 447117 [details]
Patch
Comment 5 Vitaly Dyachkov 2021-12-14 09:21:04 PST 
Is there anything I can do to speed up the review process?
Comment 6 Sergio Villar Senin 2021-12-15 01:04:04 PST 
Committed r287064 (245259@trunk): <https://commits.webkit.org/245259@trunk>
Comment 7 Radar WebKit Bug Importer 2021-12-15 01:05:21 PST 
<rdar://problem/86511194>