Bug 234244 – [css-flexbox] Absolutely positioned children should be aligned using the margin box

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[css-flexbox] Absolutely positioned children should be aligned using the margin box

[Sergio Villar Senin]

Created attachment 447009 [details]
Patch

[Vitaly Dyachkov]

Comment on attachment 447009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447009&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1687
> +    auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child);

availableAlignmentSpaceForChild() method contains an assertion: ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a positioned child?

[Sergio Villar Senin]

(In reply to Vitaly Dyachkov from comment #2)
> Comment on attachment 447009 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447009&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:1687
> > +    auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child);
> 
> availableAlignmentSpaceForChild() method contains an assertion:
> ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a
> positioned child?

Right, that's why EWS are complaining. I'll review tomorrow why that assert was added, looks like it does not make much sense.

[Sergio Villar Senin]

Created attachment 447117 [details]
Patch

[Vitaly Dyachkov]

Is there anything I can do to speed up the review process?

[Sergio Villar Senin]

Committed r287064 (245259@trunk): <https://commits.webkit.org/245259@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/86511194>