Bug 234241 - Missing includes in SessionStorage breaks non-unified builds
Summary: Missing includes in SessionStorage breaks non-unified builds
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-13 06:31 PST by Chris Lord
Modified: 2021-12-14 03:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2021-12-13 06:34 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2021-12-13 09:14 PST, Chris Lord 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2021-12-13 06:31:17 PST 
I actually hit this in unified builds after making small, unrelated changes, but presumably it also breaks non-unified builds. SessionStorage.h is missing a couple of includes.
Comment 1 Chris Lord 2021-12-13 06:34:28 PST 
Created attachment 447000 [details]
Patch
Comment 2 Chris Dumez 2021-12-13 07:22:12 PST 
Comment on attachment 447000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447000&action=review

> Source/WebKit/NetworkProcess/storage/SessionStorageManager.h:31
> +#include <WebCore/ClientOrigin.h>

Should likely be a forward declaration.
Comment 3 Chris Lord 2021-12-13 09:14:14 PST 
Created attachment 447015 [details]
Patch
Comment 4 Chris Lord 2021-12-14 03:17:20 PST 
This was fixed by unreviewed change https://trac.webkit.org/changeset/286946/webkit