Bug 234240 - GraphicsContextGLCocoa is missing a test to test all video texture upload pixel buffer formats
Summary: GraphicsContextGLCocoa is missing a test to test all video texture upload pix...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 232235
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-13 06:00 PST by Kimmo Kinnunen
Modified: 2021-12-20 06:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (12.85 KB, patch)
2021-12-13 06:05 PST, Kimmo Kinnunen 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-12-13 06:00:55 PST 
GraphicsContextGLCocoa is missing a test to test all video texture upload pixel buffer formats

This is a typical regression point
Comment 1 Kimmo Kinnunen 2021-12-13 06:05:35 PST 
Created attachment 446996 [details]
Patch
Comment 2 Dean Jackson 2021-12-13 11:05:11 PST 
Comment on attachment 446996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446996&action=review

> Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:298
> +        auto status = WebCore::CVPixelBufferCreate(kCFAllocatorDefault, 72, 128, pixelFormat, pixelBufferAttributes, &pixelBufferRef);

Maybe explain where the 72 x 128 comes from? I guess that's the size of the fake video :)
Comment 3 Radar WebKit Bug Importer 2021-12-20 06:01:16 PST 
<rdar://problem/86721110>