Bug 234233 - [GTK][a11y] Handle the Embedded method sent by AtkSocket from AccessibilityRootAtspi
Summary: [GTK][a11y] Handle the Embedded method sent by AtkSocket from AccessibilityRo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2021-12-13 04:00 PST by Carlos Garcia Campos
Modified: 2021-12-14 00:13 PST (History)
11 users (show)

See Also:

Attachments
Patch (17.89 KB, patch)
2021-12-13 04:03 PST, Carlos Garcia Campos 		aperez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (18.65 KB, patch)
2021-12-13 22:41 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-12-13 04:00:54 PST 
I added some hacks to send the socket path to the web process using WebKit IPC because Embedded message is not in the DBus interface. We can simply add the message to the interface definition and handle it instead to simplify everything.
Comment 1 Carlos Garcia Campos 2021-12-13 04:03:44 PST 
Created attachment 446986 [details]
Patch
Comment 2 Adrian Perez 2021-12-13 04:17:23 PST 
Comment on attachment 446986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446986&action=review

> Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:200
> +    m_parentPath = parentPath;

Nice, and I like it that this allows to remove the USE(GTK4) switcheroo above
and the USE(ATSPI) one down below 💪️
Comment 3 Carlos Garcia Campos 2021-12-13 22:41:02 PST 
Created attachment 447109 [details]
Patch for landing
Comment 4 Carlos Garcia Campos 2021-12-14 00:13:07 PST 
Committed r287014 (245219@trunk): <https://commits.webkit.org/245219@trunk>