Bug 234216 - Hide viewport-constrained elements that are detected by ModalContainerObserver
Summary: Hide viewport-constrained elements that are detected by ModalContainerObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 234214
Blocks:
  Show dependency treegraph
 
Reported: 2021-12-12 14:52 PST by Wenson Hsieh
Modified: 2021-12-17 21:47 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2021-12-12 16:32 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (4.79 KB, patch)
2021-12-12 21:48 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2021-12-16 13:09 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
For EWS (3.57 KB, patch)
2021-12-17 16:55 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-12-12 14:52:58 PST
.
Comment 1 Wenson Hsieh 2021-12-12 16:32:16 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-12 21:48:06 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-12-16 13:09:25 PST
Created attachment 447388 [details]
Patch
Comment 4 Tim Horton 2021-12-17 14:55:22 PST
Comment on attachment 447388 [details]
Patch

This seems to address Antti's concerns (though would be good to get his input, maybe asynchronously). Maybe move your check up beyond the unconditional quirks one?
Comment 5 Wenson Hsieh 2021-12-17 16:37:04 PST
Thanks for taking a look!

(In reply to Tim Horton from comment #4)
> Comment on attachment 447388 [details]
> Patch
> 
> This seems to address Antti's concerns (though would be good to get his
> input, maybe asynchronously). Maybe move your check up beyond the
> unconditional quirks one?

👍🏻
Comment 6 Wenson Hsieh 2021-12-17 16:55:16 PST
Created attachment 447496 [details]
For EWS
Comment 7 EWS 2021-12-17 21:46:54 PST
Committed r287219 (245382@main): <https://commits.webkit.org/245382@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447496 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-17 21:47:20 PST
<rdar://problem/86661831>