Bug 234199 – Allow override of system's preferred color scheme

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Dean Jackson]

Allow override of system's preferred color scheme

[Radar WebKit Bug Importer]

<rdar://problem/86366044>

[Dean Jackson]

Created attachment 446891 [details]
Patch

[Anders Carlsson]

Looks like all the EWS bots are red.

[Dean Jackson]

(In reply to Anders Carlsson from comment #3)
> Looks like all the EWS bots are red.

Very impressive. Do I win a prize?

[Dean Jackson]

Created attachment 447028 [details]
Patch

[Dean Jackson]

Would appreciate feedback on the SPI naming - I put the word "explicitly" in there to make it clear that this isn't the preference coming from the system.

[Tim Horton]

Comment on attachment 447028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447028&action=review

> Source/WebKit/UIProcess/API/APIWebsitePolicies.h:135
> +    WebCore::ColorSchemePreference userExplicitlyPrefersColorScheme() const { return m_userExplicitlyPrefersColorScheme; }

This getter name feels slightly odd (it sounds like it would return a boolean that the "user explicitly prefers (a) color scheme").

[Dean Jackson]

Comment on attachment 447028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447028&action=review

>> Source/WebKit/UIProcess/API/APIWebsitePolicies.h:135
>> +    WebCore::ColorSchemePreference userExplicitlyPrefersColorScheme() const { return m_userExplicitlyPrefersColorScheme; }
> 
> This getter name feels slightly odd (it sounds like it would return a boolean that the "user explicitly prefers (a) color scheme").

Do you think I should call it colorSchemePreference?

[Tim Horton]

(In reply to Dean Jackson from comment #8)
> Comment on attachment 447028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447028&action=review
> 
> >> Source/WebKit/UIProcess/API/APIWebsitePolicies.h:135
> >> +    WebCore::ColorSchemePreference userExplicitlyPrefersColorScheme() const { return m_userExplicitlyPrefersColorScheme; }
> > 
> > This getter name feels slightly odd (it sounds like it would return a boolean that the "user explicitly prefers (a) color scheme").
> 
> Do you think I should call it colorSchemePreference?

or preferredColorScheme? Or maybe shove the word "override" in there somewhere because it overrides the system preference?

[Dean Jackson]

Created attachment 447056 [details]
Patch

[Tim Horton]

Comment on attachment 447056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447056&action=review

> Source/WebCore/css/MediaQueryEvaluator.cpp:811
> +    bool useDarkAppearance = [&] () -> auto {

Are there other things that read useDarkAppearance that need to change? Should useDarkAppearance itself respect the bit on DocumentLoader?

[Antoine Quint]

There is an existing `ColorScheme` enum with holds the `Light` and `Dark` options. Maybe instead of adding a new enum you could use an std::optional<ColorScheme> where std::nullopt would indicate the lack of a preference?

[Dean Jackson]

Committed r287030 (?): <https://commits.webkit.org/r287030>