Bug 234195 - [LFC][IFC] Add partial unicode-bidi support on the block container
Summary: [LFC][IFC] Add partial unicode-bidi support on the block container
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-11 05:26 PST by zalan
Modified: 2021-12-12 15:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (11.24 KB, patch)
2021-12-11 05:33 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.23 KB, patch)
2021-12-11 06:03 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.19 KB, patch)
2021-12-11 14:59 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (54.64 KB, patch)
2021-12-11 16:59 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (54.60 KB, patch)
2021-12-11 20:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.23 KB, patch)
2021-12-12 14:36 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-11 05:26:11 PST 
ssia
Comment 1 zalan 2021-12-11 05:33:17 PST 
Created attachment 446876 [details]
Patch
Comment 2 Antti Koivisto 2021-12-11 05:54:21 PST 
Comment on attachment 446876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446876&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173
> +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi)

handline?
Comment 3 zalan 2021-12-11 05:56:06 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 446876 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446876&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173
> > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi)
> 
> handline?
yeah, totally spec language. :shrugs:
Comment 4 zalan 2021-12-11 06:03:42 PST 
Created attachment 446878 [details]
Patch
Comment 5 zalan 2021-12-11 14:59:28 PST 
Created attachment 446905 [details]
Patch
Comment 6 zalan 2021-12-11 16:59:08 PST 
Created attachment 446914 [details]
Patch
Comment 7 zalan 2021-12-11 20:00:57 PST 
Created attachment 446919 [details]
Patch
Comment 8 zalan 2021-12-12 14:36:11 PST 
Created attachment 446943 [details]
Patch
Comment 9 EWS 2021-12-12 15:50:57 PST 
Committed r286929 (245155@main): <https://commits.webkit.org/245155@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446943 [details].
Comment 10 Radar WebKit Bug Importer 2021-12-12 15:51:19 PST 
<rdar://problem/86389123>