RESOLVED FIXED Bug 234195
[LFC][IFC] Add partial unicode-bidi support on the block container 
https://bugs.webkit.org/show_bug.cgi?id=234195
Summary [LFC][IFC] Add partial unicode-bidi support on the block container
zalan
Reported 2021-12-11 05:26:11 PST
ssia
Attachments
Patch (11.24 KB, patch)
2021-12-11 05:33 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.23 KB, patch)
2021-12-11 06:03 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.19 KB, patch)
2021-12-11 14:59 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (54.64 KB, patch)
2021-12-11 16:59 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (54.60 KB, patch)
2021-12-11 20:00 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.23 KB, patch)
2021-12-12 14:36 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-12-11 05:33:17 PST
Created attachment 446876 [details] Patch
Antti Koivisto
Comment 2 2021-12-11 05:54:21 PST
Comment on attachment 446876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446876&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173 > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi) handline?
zalan
Comment 3 2021-12-11 05:56:06 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 446876 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=446876&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173 > > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi) > > handline? yeah, totally spec language. :shrugs:
zalan
Comment 4 2021-12-11 06:03:42 PST
Created attachment 446878 [details] Patch
zalan
Comment 5 2021-12-11 14:59:28 PST
Created attachment 446905 [details] Patch
zalan
Comment 6 2021-12-11 16:59:08 PST
Created attachment 446914 [details] Patch
zalan
Comment 7 2021-12-11 20:00:57 PST
Created attachment 446919 [details] Patch
zalan
Comment 8 2021-12-12 14:36:11 PST
Created attachment 446943 [details] Patch
EWS
Comment 9 2021-12-12 15:50:57 PST
Committed r286929 (245155@main): <https://commits.webkit.org/245155@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446943 [details].
Radar WebKit Bug Importer
Comment 10 2021-12-12 15:51:19 PST
<rdar://problem/86389123>
Note You need to log in before you can comment on or make changes to this bug.