Bug 234189 - Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
Summary: Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-10 17:23 PST by Tim Horton
Modified: 2021-12-10 19:45 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.29 KB, patch)
2021-12-10 17:24 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-12-10 17:23:22 PST 
Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
Comment 1 Tim Horton 2021-12-10 17:24:40 PST 
Created attachment 446850 [details]
Patch
Comment 2 Tim Horton 2021-12-10 17:24:43 PST 
<rdar://problem/86344954>
Comment 3 Simon Fraser (smfr) 2021-12-10 17:27:57 PST 
Comment on attachment 446850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review

> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123
> +        return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]);

Do we need to guard against it not being a CFNumber?
Comment 4 Tim Horton 2021-12-10 17:29:59 PST 
Comment on attachment 446850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review

>> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123
>> +        return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]);
> 
> Do we need to guard against it not being a CFNumber?

see the dynamic_cf_cast above
Comment 5 EWS 2021-12-10 19:45:00 PST 
Committed r286900 (245128@main): <https://commits.webkit.org/245128@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446850 [details].