Bug 234168 – Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate

[Tim Horton]

Created attachment 446783 [details]
Patch

[Tim Horton]

<rdar://problem/86247557>

[Simon Fraser (smfr)]

Comment on attachment 446783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446783&action=review

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp:295
> +    DisplayProperties properties;
> +    properties.displayID = displayID;
> +    properties.nominalFrameRate = nominalFramesPerSecond.value_or(WebCore::FullSpeedFramesPerSecond);

auto properties = DisplayProperties { displayID, nominalFramesPerSecond.value_or(WebCore::FullSpeedFramesPerSecond) } ?

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:78
> +        float nominalFrameRate;

Use the FramesPerSecond type?

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:144
> +        float displayNominalFrameRate { 0 };

Is this a frames per second, or a frame duration? If the former, can it use FramesPerSecond?

[Tim Horton]

Created attachment 446810 [details]
Patch

[EWS]

Committed r286919 (245145@main): <https://commits.webkit.org/245145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446810 [details].