Bug 234132 - [WPE] Unable to launch Cog browser with run-minibrowser
Summary: [WPE] Unable to launch Cog browser with run-minibrowser
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-10 01:50 PST by Philippe Normand
Modified: 2021-12-10 07:34 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2021-12-10 01:53 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2021-12-10 02:11 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-12-10 01:50:53 PST 
Its path changed....
Comment 1 Philippe Normand 2021-12-10 01:53:06 PST 
Created attachment 446687 [details]
Patch
Comment 2 Philippe Normand 2021-12-10 02:11:57 PST 
Created attachment 446690 [details]
Patch
Comment 3 Adrian Perez 2021-12-10 06:28:21 PST 
The binary moved as a result of merging https://github.com/Igalia/cog/pull/376
I think it will be nicer to change the CMakeLists.txt in Cog to make it place
the compiled binaries inside the top build directory instead of in the “launcher/”
subdirectory — when developing I would rather run ”./build/cog …” to tests things
rather than “./build/launcher/cog …“

OTOH, I think it is valuable to add the unit test anyway, so it's easier to
catch the problem if the binaries get accidentally moved again :)
Comment 4 Adrian Perez 2021-12-10 06:37:24 PST 
Location set to the old one in https://github.com/Igalia/cog/pull/383 :)