Bug 234119 – AX: role="button" with aria-pressed is not exposed as a form control

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Sepand Parhami]

Summary:
When using an element with `role=“button”` and `aria-pressed`, the element does not correctly show up in VoiceOver’s form controls menu, like regular buttons with aria-pressed or elements with just the role.

Steps To Reproduce:
1. Open the attached repro.html in Safari
2. Enable VoiceOver
3. Open web rotor (control + option + u)
4. Navigate to form controls (left or right arrow until it appears)

Results:
There is only one button in the forms control menu, the plain HTML button. I would expect that the one with the aria role would also show up there.

[Radar WebKit Bug Importer]

<rdar://problem/86302258>

[Sepand Parhami]

Created attachment 446654 [details]
Patch

[chris fleizach]

Comment on attachment 446654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446654&action=review

> Source/WebCore/ChangeLog:11
> +        Tests: LayoutTests\accessibility\mac\search-predicate-element-count.html

wrong format for slashes, they should be the other way

> LayoutTests/accessibility/mac/search-predicate-element-count.html:54
> +<!-- The following two are toggle buttons. -->

it doesn't look like this tests the new behavior. toggle buttons have aria_pressed as attributes.

[Sepand Parhami]

Created attachment 446757 [details]
Patch

[Sepand Parhami]

Comment on attachment 446654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446654&action=review

>> Source/WebCore/ChangeLog:11
>> +        Tests: LayoutTests\accessibility\mac\search-predicate-element-count.html
> 
> wrong format for slashes, they should be the other way

Fixed.

>> LayoutTests/accessibility/mac/search-predicate-element-count.html:54
>> +<!-- The following two are toggle buttons. -->
> 
> it doesn't look like this tests the new behavior. toggle buttons have aria_pressed as attributes.

Oops, fixed.

[EWS]

Committed r288100 (246114@main): <https://commits.webkit.org/246114@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446757 [details].