Provide SPI to export/import local credentials.
rdar://84822000
Created attachment 446722 [details] Patch
Reminder to make these SPIs synchronous.
Created attachment 449981 [details] Patch
Comment on attachment 449981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449981&action=review > Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h:80 > const char LocalAuthenticatiorAccessGroup[] = "com.apple.webkit.webauthn"; Misspelled word "authenticator" here. > Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h:87 > +const char privateKeyKey[] = "priv"; > +const char keyTypeKey[] = "key_type"; > +const char keySizeKey[] = "key_size"; > +const char relyingPartyKey[] = "rp"; > +const char applicationTagKey[] = "tag"; constexpr?
Created attachment 449987 [details] Patch
Comment on attachment 449987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449987&action=review r=me > Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h:80 > +constexpr const char LocalAuthenticatorAccessGroup[] = "com.apple.webkit.webauthn"; Thank you for fixing that typo! > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:397 > + *error = [NSError errorWithDomain:WKErrorDomain code:WKErrorMalformedCredential userInfo:nil]; This little check and assignment is repeated so many times it might be nice as a static function: static void createMalformedCredentialErrorIfNecessary(NSError **error) > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:488 > + *error = [NSError errorWithDomain:WKErrorDomain code:WKErrorDuplicateCredential userInfo:nil]; ... or, perhaps a helper that takes the WKError type: static void createNSErrorFromWKErrorIfNecessary(NSError **error, WKErrorCode errorCode) { if (error) *error = [NSError errorWithDomain:WKErrorDomain code: errorCode userInfo:nil]; }
Created attachment 450088 [details] Patch
Created attachment 450089 [details] Patch for landing
Committed r288816 (246592@main): <https://commits.webkit.org/246592@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450089 [details].