Bug 234110 - [LFC][IFC] Replace Vector<std::unique_ptr<DisplayBoxNode> with Vector<DisplayBoxTree::Node>
Summary: [LFC][IFC] Replace Vector<std::unique_ptr<DisplayBoxNode> with Vector<Display...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-09 15:59 PST by zalan
Modified: 2021-12-10 08:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.05 KB, patch)
2021-12-09 16:11 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.93 KB, patch)
2021-12-10 07:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-09 15:59:35 PST 
as suggested in bug 233880
Comment 1 zalan 2021-12-09 16:11:41 PST 
Created attachment 446627 [details]
Patch
Comment 2 Antti Koivisto 2021-12-10 06:05:57 PST 
Comment on attachment 446627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446627&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:347
> +        // Node index in m_displayBoxNodes.
> +        size_t thisIndex { 0 };

This doesn't appear to be used.
Comment 3 zalan 2021-12-10 07:46:01 PST 
Created attachment 446727 [details]
Patch
Comment 4 EWS 2021-12-10 08:21:53 PST 
Committed r286851 (245084@main): <https://commits.webkit.org/245084@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446727 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-10 08:22:20 PST 
<rdar://problem/86322728>