Bug 234107 – 'run-benchmark' should launch browsers in a relative clean state.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

'run-benchmark' should launch browsers in a relative clean state.

Created attachment 446624 [details]
Patch

<rdar://85831161>

[Stephanie Lewis]

Comment on attachment 446624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446624&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:34
> +        chrome_options.add_argument("--disable-extensions")

did you want disable-extensions in two places?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:41
> +        return '--window-size={width},{height}'.format(width=int(screen_size.width), height=int(screen_size.height))

does setting window size set content size or window size?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:33
> +        args_with_url = ['--args', '-width', str(int(screen_size.width)), '-height', str(int(screen_size.height))]

Do we really run  fullscreen?
Same question does this set content size or window size because Chrome, Firefox, and Safari often have different sized chromes and we want the content size to match

Comment on attachment 446624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446624&action=review

>> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:34
>> +        chrome_options.add_argument("--disable-extensions")
> 
> did you want disable-extensions in two places?

Those are different, one for webdriver, one for launch with 'open' command.

>> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:41
>> +        return '--window-size={width},{height}'.format(width=int(screen_size.width), height=int(screen_size.height))
> 
> does setting window size set content size or window size?

It will fill the screen, that's what we want.

>> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:33
>> +        args_with_url = ['--args', '-width', str(int(screen_size.width)), '-height', str(int(screen_size.height))]
> 
> Do we really run  fullscreen?
> Same question does this set content size or window size because Chrome, Firefox, and Safari often have different sized chromes and we want the content size to match

This will not be full screen, it will fill screen without overlapping with docker.

Comment on attachment 446624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446624&action=review

>>> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:41
>>> +        return '--window-size={width},{height}'.format(width=int(screen_size.width), height=int(screen_size.height))
>> 
>> does setting window size set content size or window size?
> 
> It will fill the screen, that's what we want.

Discussed in person. It looks like MotionMark is immune from slightly window height change and speedometer2 doesn't show significant change (100 iteration) with slightly different window size.

Landed in r287289.