Bug 234095 - [Playstation] Fix build break after r286751 with INTELLIGENT_TRACKING_PREVENTION enabled
Summary: [Playstation] Fix build break after r286751 with INTELLIGENT_TRACKING_PREVENT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jigen Zhou
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-09 11:34 PST by Jigen Zhou
Modified: 2021-12-09 20:51 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2021-12-09 12:02 PST, Jigen Zhou
no flags Details | Formatted Diff | Diff
Patch (1.23 KB, patch)
2021-12-09 12:55 PST, Jigen Zhou
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jigen Zhou 2021-12-09 11:34:04 PST
In file included from WebKit/DerivedSources/unified-sources/UnifiedSource-72468c22-4.cpp:1:
In file included from C:/work/webkit/jenkins/neko/Source/WebKit\NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:32:
C:/work/webkit/jenkins/neko/Source/WebKit/NetworkProcess\NetworkSession.h:197:174: error: no type named 'ResourceError' in namespace 'WebCore'
    virtual void requestResource(WebPageProxyIdentifier, WebCore::ResourceRequest&&, CompletionHandler<void(const IPC::DataReference&, WebCore::ResourceResponse&&, WebCore::ResourceError&&)>&&) { }
                                                                                                                                                                    ~~~~~~~~~^
1 error generated.
Comment 1 Jigen Zhou 2021-12-09 12:02:12 PST
Created attachment 446585 [details]
Patch
Comment 2 Don Olmstead 2021-12-09 12:26:32 PST
Comment on attachment 446585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446585&action=review

> Source/WebKit/NetworkProcess/NetworkSession.h:44
> +#include <WebCore/ResourceError.h>

Can you confirm that a forward declaration wouldn't resolve the issue?

Ideally we only include what we absolutely need to in the header file.
Comment 3 Jigen Zhou 2021-12-09 12:55:41 PST
Created attachment 446593 [details]
Patch

Yes, a forward declaration works. Thanks.
Comment 4 EWS 2021-12-09 20:50:02 PST
Committed r286830 (245063@main): <https://commits.webkit.org/245063@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446593 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-09 20:51:23 PST
<rdar://problem/86305720>